Expire any admin console sessions if user admin rights revoked#1331
Merged
GregDThomas merged 1 commit intoigniterealtime:masterfrom Apr 14, 2019
Merged
Expire any admin console sessions if user admin rights revoked#1331GregDThomas merged 1 commit intoigniterealtime:masterfrom
GregDThomas merged 1 commit intoigniterealtime:masterfrom
Conversation
Contributor
|
The one-time token is created by editing the |
GregDThomas
approved these changes
Apr 14, 2019
Contributor
|
Many thanks! I've tracked this as https://issues.igniterealtime.org/browse/OF-1734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to reproduce on HEAD:
(1) Create a second administrator account "dan"
(2) Using web browser 1 log in as "dan" and open up the sessions list in the admin console
(3) User web browser 2 log in as other admin, and revoke the admin permission for "dan"
(4) Dan can still refresh and use the admin console
I've tested the regular paths with admin console users - but in all honesty I haven't tested the "auth token" path (although the code seems OK to my eyes).
How is the auth-token path exercised? (Clustering maybe?)