Adaptive condensation substepping #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of substeps; sanity checks; outline of logic in step
…code), some issues with pparticle with mixing
…nt have to be a power of 2
…ersubstep loop: get rid of unconverged_mask and dont pass sstp_cond iterators
Collaborator
|
🚀 |
… into sstp_cond_adaptive
There was a problem hiding this comment.
Pull request overview
This pull request implements adaptive condensation substepping for particle-based cloud microphysics simulations. The key changes include:
- Implementation of adaptive per-particle condensation substepping algorithm
- Refactoring code organization by moving implementation files into logical subdirectories (initialization/, condensation/, housekeeping/, etc.)
- New comprehensive test suite for condensation substepping with reference data comparison
- Updates to existing condensation logic to support both per-cell and per-particle substepping modes
Reviewed changes
Copilot reviewed 64 out of 120 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/python/unit/sstp_cond.py | Updated unit test with commented debug code |
| tests/python/physics/lgrngn_cond_substepping.py | New comprehensive test script for condensation substepping |
| tests/python/physics/lgrngn_cond_substepping_test.py | New comparison test against reference data |
| tests/python/physics/lgrngn_cond_substepping_plot.py | New plotting utility for visualization |
| tests/python/physics/refdata/lgrngn_cond_substepping_refdata.csv | New reference data file (281 lines) |
| tests/python/physics/README_cond_substepping.md | New documentation for test workflow |
| tests/python/physics/CMakeLists.txt | Updated to register new tests |
| tests/python/physics/lgrngn_cond.py | Updated with commented assertions |
| src/particles_step.ipp | Major refactoring of condensation stepping logic |
| src/particles_init.ipp | Updates to initialization for new features |
| src/particles_diag.ipp | Minor diagnostic updates |
| src/particles.tpp | Reorganization of include files into subdirectories |
| src/impl/particles_impl.ipp | Core data structure updates for adaptive substepping |
| src/impl/initialization/* | Multiple initialization files moved/created |
| src/impl/condensation/* | New condensation implementation files |
| src/impl/housekeeping/* | Housekeeping files reorganized |
| src/impl/sources_and_relaxation_of_SDs/* | Source/relaxation files reorganized |
| Various other impl files | Files moved to appropriate subdirectories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.