Ice in super-droplets #462
Conversation
…t was added to outliq_vol
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 68 out of 69 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 68 out of 69 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
|
|
||
| template <typename real_t, backend_t device> |
There was a problem hiding this comment.
Add a turb_cond option as in cond(), or add a sanity check that deposition doesnt work (yet) with turb_cond
There was a problem hiding this comment.
I added a sanity check
| } | ||
| if (opts_init.ice_switch && opts_init.time_dep_ice_nucl) | ||
| { | ||
| tmp_device_real_part.add_vector(); |
There was a problem hiding this comment.
Why is an additional vector needed? Is it needed even if (allow_sstp_cond && opts_init.exact_sstp_cond), in which case there are more tmp_device_real_part vectors?
3 participants
Ice as in Shima et al. (2020), with time-dependent freezing
To consider: