Skip to content

Fix error#154

Open
devanshu-puri wants to merge 10 commits intoidna001:masterfrom
devanshu-puri:fix-error
Open

Fix error#154
devanshu-puri wants to merge 10 commits intoidna001:masterfrom
devanshu-puri:fix-error

Conversation

@devanshu-puri
Copy link
Copy Markdown

@devanshu-puri devanshu-puri commented Oct 11, 2025

Error fixed

image ![Uploading image.png…]()

devanshu and others added 7 commits October 7, 2025 13:56
Fix ReferenceError by removing obsolete hint refs and updating cleanu…
4142987 
…p logic
Refactor: cleaned up hint logic, fixed reference errors, and updated …
9c3ffc1 
…structure for stability
Refactor hint system into custom hook and fix shuffle logic
7ab523b
@idna001
Merge branch 'master' into fix-hint-error
6f96ca5 
Signed-off-by: Andreas V <46223359+idna001@users.noreply.github.com>
@idna001
Update src/App.js
9fe002c 
Signed-off-by: Andreas V <46223359+idna001@users.noreply.github.com>
@devanshu-puri
Merge branch 'master' into fix-hint-error
deb0928 
Signed-off-by: CodeKenshinDev <72023898+devanshu-puri@users.noreply.github.com>
fixed the app.js
729f892
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2025

Someone is attempting to deploy a commit to the idna001's projects Team on Vercel.

A member of the Team first needs to authorize it.

@devanshu-puri
Copy link
Copy Markdown
Author

devanshu-puri commented Oct 11, 2025

@idna001 According to sonarcloud there is issue but it's related to some crypo issue as we use math.random(), but there is no password thing so it is fine here .

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
aa-memory Ready Ready Preview Comment Oct 11, 2025 6:43pm

idna001
idna001 requested changes Oct 11, 2025
View reviewed changes
Copy link
Copy Markdown
Owner

@idna001 idna001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR the hint feature shows one right pair, is this like it should be?
Other thing it breaks the theme switcher..

@idna001
Copy link
Copy Markdown
Owner

idna001 commented Oct 11, 2025

@devanshu-puri

@idna001 According to sonarcloud there is issue but it's related to some crypo issue as we use math.random(), but there is no password thing so it is fine here .

Why not just solve it like mentioned on Sonar?

@devanshu-puri
Copy link
Copy Markdown
Author

devanshu-puri commented Oct 11, 2025

@idna001 np will update it according to sonarCloud

@idna001
Copy link
Copy Markdown
Owner

idna001 commented Oct 11, 2025

@devanshu-puri and maybe watch my other point:

@devanshu-puri

@idna001 According to sonarcloud there is issue but it's related to some crypo issue as we use math.random(), but there is no password thing so it is fine here .

Why not just solve it like mentioned on Sonar?

:)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 11, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idna001 idna001 idna001 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devanshu-puri @idna001