Fix correctness issues in skills, hooks, and dependency checks#10
Merged
samuelduchesne merged 1 commit intoMay 27, 2026
Merged
Conversation
Address shortcomings found in an expert review of the plugin's skills:
- upgrade-version: rewrite around the migrate_model tool (official
IDFVersionUpdater transition chain) instead of hand-copying objects into
a new_model, which silently corrupts models across version field/default
changes. Add forward-only guard and EnergyPlus precondition.
- inject-idf-context.sh: emit PreToolUse hookSpecificOutput.additionalContext
JSON so the guidance actually reaches the model (plain stdout is ignored on
PreToolUse); parse file_path via jq; drop the nonexistent get_object tool.
- simulate / quick-sim: add the design-day sizing gate before annual runs and
correct the unmet-hours criterion to ASHRAE 90.1 G3.1.2.3 (<=300 occupied
hours each for heating and cooling, not a summed total).
- validate: replace the fabricated Critical/Reference/Warning/Info taxonomy
with the real ValidationResult shape (ERROR/WARNING/INFO + E0xx/W0xx codes).
- new-model: note new_model seeds only four objects; add required Timestep,
RunPeriod, Site:Location, infiltration, thermostats, and sizing objects.
- idf-conventions / energy-modeler: drop stale hardcoded tool/resource counts
and version pins in favor of the live tool surface; fix the vertex example
to the structured vertices array.
- check-deps.sh: select the newest EnergyPlus install via sort -V instead of
the lexically-last glob match.
- developing-with-idfkit: use the ${CLAUDE_SKILL_DIR} token so the command
matches the allowed-tools permission pattern.
https://claude.ai/code/session_01MvFYZxrFeVbiTfnvBVgNRr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address shortcomings found in an expert review of the plugin's skills:
IDFVersionUpdater transition chain) instead of hand-copying objects into
a new_model, which silently corrupts models across version field/default
changes. Add forward-only guard and EnergyPlus precondition.
JSON so the guidance actually reaches the model (plain stdout is ignored on
PreToolUse); parse file_path via jq; drop the nonexistent get_object tool.
correct the unmet-hours criterion to ASHRAE 90.1 G3.1.2.3 (<=300 occupied
hours each for heating and cooling, not a summed total).
with the real ValidationResult shape (ERROR/WARNING/INFO + E0xx/W0xx codes).
RunPeriod, Site:Location, infiltration, thermostats, and sizing objects.
and version pins in favor of the live tool surface; fix the vertex example
to the structured vertices array.
the lexically-last glob match.
matches the allowed-tools permission pattern.
https://claude.ai/code/session_01MvFYZxrFeVbiTfnvBVgNRr