Switch from js-sha3 and blake to audited noble-hashes#547
Merged
OBrezhniev merged 6 commits intoiden3:masterfrom Apr 3, 2025
paulmillr:noble-2
Merged
Switch from js-sha3 and blake to audited noble-hashes#547OBrezhniev merged 6 commits intoiden3:masterfrom paulmillr:noble-2
OBrezhniev merged 6 commits intoiden3:masterfrom
paulmillr:noble-2
Conversation
This was referenced Jan 20, 2025
OBrezhniev
reviewed
Jan 25, 2025
Member
|
@Kolezhniuk can you please test this build on our multiplatform tests setup? |
Contributor
@OBrezhniev Tested, our js-sdk works fine with with this version of snarkjs. I don't think that this is critical because warning is for builds targeted on NodeJS |
Member
|
@Kolezhniuk I've fixed rollup warnings and few other things. Can you review & recheck js-sdk tests? |
OBrezhniev
approved these changes
Mar 25, 2025
Contributor
Author
|
@OBrezhniev I see the pull requests have been merged; however this one and iden3/circomlib#119 still persist. |
Member
|
Hi @paulmillr! Yes, there was some WIP on my side there. Now both are merged. Thank you very much for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noble cryptography (https://github.com/paulmillr/noble-hashes) is high-security, easily auditable set of contained cryptographic libraries and tools. It would be great to use it instead of some unknown library. Benefits:
All PRs:
Originally proposed 15 months ago in #416