Open
Conversation
Author
|
I should note that it is easy to mistakenly add a condition such as 'n == 5' instead, which will never be true. I'm not sure why gdb requires the if, and maybe it should be hidden inside vebugger, actually. That would mean we need to test if there is a non-empty condition, and only add 'if '.l:breakpoint.condition if the string is non-empty. |
Author
|
Although it would still be better to show the condition of a conditional breakpoint as soon as you put the cursor over it, I just realised an easy way to show the condition is to edit it again using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for conditional breakpoints for gdb. To test this; I used the following fizzbuzz in C++:
Using this branch, I can add a breakpoint for instance on line 6 with
<vebugger-leader>kand then type inif n == 5. Everything I tested works:Note: I have not yet tested other debuggers than gdb. Presumably we should add it for others that support it as well.
Adding support for #95 was easier than I thought!