Docker provisionally done #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aak523
requested changes
Jan 23, 2026
Collaborator
aak523
left a comment
aak523
left a comment
There was a problem hiding this comment.
Great HackPack, just a few minor changes needed.
| > [!NOTE] | ||
| > The binaries are available for Windows too, but they don't include _Compose_, which we'll use later. | ||
|
|
||
| You can also install [_Podman_](https://podman.io/docs/installation), a drop-in replacement for Docker for Windows, Linux and MacOS (just replace the `docker` in commands with `podman`). |
Collaborator
There was a problem hiding this comment.
Is it worth mentioning Podman without justifying its use? I would say either add an explanation of why you might choose it over Docker (open-source, lightweight) or scrap this suggestion entirely.
|
|
||
| ### Compose | ||
|
|
||
| To get Postgres working, you need to set an environment variable for the password: |
Collaborator
There was a problem hiding this comment.
I understand the approach of introducing a problem before the solution, but it does feel a bit abrupt to start talking through the Postgres example with zero context.
Could explain the relevance of Postgres with a placeholder link to where it would be in the databases HackPack?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.