Conversation
|
Alright, fixed the conflicts. |
There was a problem hiding this comment.
I left a couple of (hopefully minor) comments, otherwise this looks good. I appreciate the thoroughness here.
Is the MSRV bump absolutely necessary, or are there ways to work around the features being used? 1.81 is quite a big jump, but I wouldn't consider it a breaking change.
|
So re MSRV concerns, the currently used features that are nontrivial to replace are:
Polyfilling the later (either inline or with a helper) is possible, yes, so I could implement that. The former is not possible to polyfill, but I could just panic in (also, thoughts on |
|
Can you use Yeah, we can re-export until the next breaking change. |
|
…You’re right, I’m embarrassed I forgot |
Once in a blue moon I have to think about unwind safety, and every time I do I forget everything I learnt last time.
|
This looks great, thanks! I'll cut a release soon. |
Split off from #31. The notes from #31 (comment) still apply.
(Right… I need to fix merge conflicts. I will do so soon.)