1120: CI-only: create detect-secrets baseline file#1
Open
spinler wants to merge 1 commit intoibm-openbmc:1120from
Open
1120: CI-only: create detect-secrets baseline file#1spinler wants to merge 1 commit intoibm-openbmc:1120from
spinler wants to merge 1 commit intoibm-openbmc:1120from
Conversation
This creates a baseline file (and initial responses to any potential secrets found). After this file is merged, all CI jobs after will run the detect-secrets tool against incoming commits to verify no potential secrets are being shared. If one is found, CI will fail until the .secrets.baseline is updated for the new issue. See the following for more info: https://github.com/IBM/detect-secrets Change-Id: I78eb8241e520cc410cfa34238bb7b3422df0383f Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Contributor
Author
|
Is this needed if CI isn't enabled? |
Contributor
|
Good point, CI has been enabled. The agreement is anything we fork into ibm-openbmc has CI and this secrets check. |
Contributor
|
Although now that you got https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/84366 merged upstream can we just go back to using upstream? |
Contributor
Author
When I tried to build an image with the latest sdbusplus master ipmi-host fails with: which has fails Also I see there are python3-sdbus++_git.bb changes |
geissonator
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a baseline file (and initial responses to any potential secrets found).
After this file is merged, all CI jobs after will run the detect-secrets tool against incoming commits to verify no potential secrets are being shared. If one is found, CI will fail until the .secrets.baseline is updated for the new issue.
See the following for more info: https://github.com/IBM/detect-secrets
Change-Id: I78eb8241e520cc410cfa34238bb7b3422df0383f