[major] FVT Implement Workflow for Saas AI Services#2310
Open
joshiricha444 wants to merge 252 commits into
Open
[major] FVT Implement Workflow for Saas AI Services#2310joshiricha444 wants to merge 252 commits into
joshiricha444 wants to merge 252 commits into
Conversation
MASSREMAT-102 Update health check for datasciencecluster
initial commit for the minio
resolved file issue.
…age/cli/mascli/functions/. $CLI_DIR/functions/gitops_aibroker change in file name
code updated for checking values present in aws
joshiricha444
changed the title
boonware
reviewed
May 26, 2026
| # Skip DRO, S3, and JDBC secret validation in FVT environments | ||
| # These secrets will be created by postSync jobs after deployment | ||
| if [[ "${IS_GITOPS_FVT_ENV}" != "true" ]]; then | ||
| sm_verify_secret_exists ${SECRETS_PREFIX}ibm_entitlement "image_pull_secret_b64,entitlement_key" |
Contributor
There was a problem hiding this comment.
The entitlement_key secret is being skipped when not in FVT. Is this one not required for pulling images?
boonware
reviewed
May 26, 2026
| sm_verify_secret_exists ${SECRETS_PREFIX}s3 "sm_s3_accesskey,sm_s3_secretkey,sm_s3_host,sm_s3_region" | ||
| sm_verify_secret_exists ${SECRETS_PREFIX}jdbc "jdbccfg_username,jdbccfg_password,jdbccfg_url,jdbccfg_sslenabled,jdbccfg_ca_b64enc" | ||
| else | ||
| echo "IS_GITOPS_FVT_ENV is true - Skipping DRO, S3, and JDBC secret validation" |
Contributor
There was a problem hiding this comment.
It would be useful to explain why we do this in the PR description and/or a comment here in the code.
boonware
reviewed
May 26, 2026
| @@ -0,0 +1,253 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
How is this KModel deprovisioning related to FVT? Can we remove this?
boonware
reviewed
May 26, 2026
| --sm-aws-secret-region ${TEXT_RESET}SM_AWS_REGION${TEXT_RESET} AWS Region | ||
| --sm-aws-access-key ${TEXT_RESET}SM_AWS_ACCESS_KEY${TEXT_RESET} AWS Access key ID | ||
| --sm-aws-secret-key ${TEXT_RESET}SM_AWS_SECRET_ACCESS_KEY${TEXT_RESET} AWS Secreat Access key ID | ||
| -i, --aiservice-instance-id ${COLOR_YELLOW}AISERVICE_INSTANCE_ID${TEXT_RESET} AI Service instance ID |
Contributor
There was a problem hiding this comment.
How is ODH deprovisioning related to FVT? Can we remove this change?
boonware
reviewed
May 26, 2026
| @@ -0,0 +1,452 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Same as above. Can we remove this?
boonware
reviewed
May 26, 2026
| @@ -122,7 +122,13 @@ function gitops_odh_noninteractive() { | |||
| export ODH_OPERATOR_VERSION="${ODH_OPERATOR_VERSION:-"opendatahub-operator.v2.19.0"}" | |||
| export ODH_NAMESPACE="${ODH_NAMESPACE:-"opendatahub"}" | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Same as above. Can we remove this?
boonware
reviewed
May 26, 2026
| @@ -0,0 +1,49 @@ | |||
| merge-key: "{{ ACCOUNT_ID }}/{{ CLUSTER_ID }}/{{ AISERVICE_INSTANCE_ID }}" | |||
Contributor
There was a problem hiding this comment.
Same as above. Can we remove this?
boonware
reviewed
May 26, 2026
| aiservice_namespace: {{ AISERVICE_NAMESPACE }} | ||
| pull_secret_name: "<path:{{ SECRETS_PATH }}:{{ SECRET_KEY_IMAGE_PULL_SECRET_B64 }}>" | ||
|
|
||
| # ODH Pipeline operator |
Contributor
There was a problem hiding this comment.
Same as above. Can we remove this?
boonware
reviewed
May 26, 2026
| gitops | ||
| ;; | ||
|
|
||
| gitops-kmodel) |
Contributor
There was a problem hiding this comment.
Same as above. Can we remove this?
boonware
reviewed
May 26, 2026
| @@ -0,0 +1,192 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
Is deprovisioning of AI Service needed for FVT? Can we remove this?
boonware
reviewed
May 26, 2026
| @@ -124,45 +124,6 @@ spec: | |||
| - name: configs | |||
| workspace: configs | |||
Contributor
There was a problem hiding this comment.
Why are we editing the MAS deprovisioning. Can we remove this?
added 2 commits
May 27, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
MASAIB-2258
Description
This PR adds support for FVT environments in AI Service SaaS deployments.
FVT environments need to deploy AI Service instances as standalone application.
Testing Resluts:
Testing results includes succesful pipeline runs for the aiservice pipeline, aiservice instance and tenant level pipelines.