Fixed a bug on not showing images in iOS14 on YYAnimatedImageView#150
Open
alisamaiee wants to merge 1 commit intoibireme:masterfrom
Open
Fixed a bug on not showing images in iOS14 on YYAnimatedImageView#150alisamaiee wants to merge 1 commit intoibireme:masterfrom
alisamaiee wants to merge 1 commit intoibireme:masterfrom
Conversation
|
Any eta on merge? |
|
Hi @alisamaiee. Maybe that has already happened, but have you considered submitting this same PR to https://github.com/yykits/yyimage as well? That repository seems still maintained. |
mpretty-cyro
added a commit
to oxen-io/session-ios-yyimage
that referenced
this pull request
Jun 26, 2024
• Fix an iOS 14 issue where YYAnimatedImageView wasn't showing images - ibireme#150 • Fix a memory leak where an CGImageRef wasn't getting released - ibireme#126 • Fix a WebP crash - zliuqing@cc510c3 • Fixed an image orientation issue - ibireme#109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS 13: If we override this, UIKit will render the UIImageView.image itself before calling this method. So even if self.currentFrame == nil, the UIImageView.image get rendered.
On iOS 14: UIKit no longer render anything if you override that displayLayer: method. We can have a backup to render layer.contents for this case by ourself.