Add build log to deployment notification email#631
Add build log to deployment notification email#631miles-grant-ibigroup wants to merge 4 commits intodevfrom
Conversation
| get(apiPrefix + "secure/deployments/:id/download", DeploymentController::downloadDeployment); | ||
| get(apiPrefix + "secure/deployments/:id/artifact", DeploymentController::downloadBuildArtifact); | ||
| // This path allows the downloaded artifact file to be named anything | ||
| get(apiPrefix + "secure/deployments/:id/artifact/:ignored", DeploymentController::downloadBuildArtifact); |
There was a problem hiding this comment.
@miles-grant-ibigroup This is confusing me. If the value is ignored, why can't the end point above be used?
There was a problem hiding this comment.
Without it, we can't make a call to .../artifact/blah.json which means we have to call it as .../artifact which means the downloaded file is downloaded as artifact which is no good.
There was a problem hiding this comment.
ok, that makes sense. Can you update the comment with this explanation please and perhaps call it :expectedFileName instead of :ignored?
There was a problem hiding this comment.
Good idea!
br648
left a comment
br648
left a comment
There was a problem hiding this comment.
Just the one item to address, but approving.
| get(apiPrefix + "secure/deployments/:id/download", DeploymentController::downloadDeployment); | ||
| get(apiPrefix + "secure/deployments/:id/artifact", DeploymentController::downloadBuildArtifact); | ||
| // This path allows the downloaded artifact file to be named anything | ||
| get(apiPrefix + "secure/deployments/:id/artifact/:ignored", DeploymentController::downloadBuildArtifact); |
There was a problem hiding this comment.
ok, that makes sense. Can you update the comment with this explanation please and perhaps call it :expectedFileName instead of :ignored?
miles-grant-ibigroup
assigned
JymDyerIBI and
binh-dam-ibigroup and unassigned
miles-grant-ibigroup and
JymDyerIBI
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
The link alone is not going to work as written. I think it needs to go to datatools UI first where the download can be triggered.
src/main/java/com/conveyal/datatools/manager/controllers/api/DeploymentController.java
Show resolved
Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/NotifyUsersForSubscriptionJob.java
Show resolved
Hide resolved
miles-grant-ibigroup
force-pushed
the
build-log-in-email
branch
from
851db20 to
c1982de
Compare
4 participants
To accomplish this, I've added a new redirect-capable artifact download endpoint