[ibexa/experience] Explicitly declared Gregwar\CaptchaBundle in bundles list#113
Draft
[ibexa/experience] Explicitly declared Gregwar\CaptchaBundle in bundles list#113
Conversation
|
Thanks for contribution! 🎉 To test the changes please execute: before executing the recipes. |
|
Member
|
@alongosz Rebase is needed here |
390c818 to
21647a2
Compare
|
Member
Author
|
@adamwojs rebased, however the issue at hand has been postponed. Does this mean that I'm supposed to be working on this next? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Related PRs:
Description:
Seems in some cases, like an upgrade from 4.5.6 to 4.6.2 (executed on the installed version from the tag, not x-dev), since
Gregwar\CaptchaBundlein not explicitly listed in our bundles manifest, its placement in the bundles list is arbitrary (I'm guessing from some generic Symfony bundles recipe). It needs to be placed after Twig Bundle, because it relies directly on a parameter declared by Twig extension.$ php bin/console cache:clear
We require anyway that bundle in the Product, so maybe there's nothing wrong with declaring it explicitly?
TODO