Initial commits rolling piston compressor#35
Open
davideziviani wants to merge 2 commits intomasterfrom
Open
Conversation
ibell
requested changes
May 25, 2019
Owner
ibell
left a comment
ibell
left a comment
There was a problem hiding this comment.
Can you please clarify what happened with the ValveModel? Is this a breaking change for other code? Wasn't this in a cython module before?
PDSim/heattransfer/HTC.py
Outdated
| beta = 1/T_film # [1/K] | ||
|
|
||
| # Transport properties calcualtion film | ||
| StateFilm=State.State(Ref,dict(T=T_film, P=P_film)) # use the film temperature to find the outer convective coefficient |
PDSim/heattransfer/HTC.py
Outdated
| Return | ||
| h [kW/m^2 K]: Heat transfer coefficient | ||
| """ | ||
| g = 9.8 # gravity acceleration [m/s^2] |
PDSim/flow/ValveModels.py
Outdated
| # the end of nozzle model | ||
| ################################################### | ||
|
|
||
| # if __name__ == '__main__': |
Owner
There was a problem hiding this comment.
Please delete these commented lines at end
examples/rollingpiston_compressor.py
Outdated
| rolling.b = 4.7e-3 #Vane thickness [m] | ||
| rolling.hv = 27.8e-3 #Vane height [m] | ||
| rolling.L_slot = 15.2e-3 #Length of vane slot [m] | ||
| rolling.Hshell = 100e-3 #Height of compressor shell |
examples/rollingpiston_compressor.py
Outdated
| rolling.L_slot = 15.2e-3 #Length of vane slot [m] | ||
| rolling.Hshell = 100e-3 #Height of compressor shell | ||
| rolling.Rshell = 40e-3 #compressor shell outer diameter | ||
| rolling.Nmot = 2875 #Electric motor rotational speed |
Collaborator
Author
|
Had some issues related to passing keys due to enconde/decode. Working on debugging the cython code. I am going to fix the different edits. |
Owner
|
I can sympathize, have spent many hours debugging that... In the cython code, the thing that seems to be the most reliable is to use string everywhere... |
Collaborator
Author
|
Yes, that is what I figured by looking at your code. I will work on it next. |
Owner
|
What's the status on the valve model stuff? |
Collaborator
Author
|
I will push updated files as next task for me! |
Owner
|
Looking forward to it!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.