Add PRD JSON validation to catch syntax errors early#9
Open
brooksy4503 wants to merge 2 commits intoiannuttall:mainfrom
Open
Add PRD JSON validation to catch syntax errors early#9brooksy4503 wants to merge 2 commits intoiannuttall:mainfrom
brooksy4503 wants to merge 2 commits intoiannuttall:mainfrom
Conversation
- Validate PRD JSON after agent generation in loop.sh - Exit with clear error message if JSON is invalid - Prevents silent failures during build phase - Catches common LLM syntax errors like mismatched brackets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When LLMs generate PRD JSON files, they occasionally make syntax errors (e.g., using
}instead of]for array closure). This causes a cryptic error message during the build phase: "Could not parse stories from PRD", making it hard to debug.Solution
Added JSON validation in
loop.shimmediately after the agent generates the PRD. If invalid JSON is detected:Testing
}instead of])