Avoid failing early when we cannot find symbols on macho#63
Open
tkonolige wants to merge 1 commit intoianlancetaylor:masterfrom
Open
Avoid failing early when we cannot find symbols on macho#63tkonolige wants to merge 1 commit intoianlancetaylor:masterfrom
tkonolige wants to merge 1 commit intoianlancetaylor:masterfrom
Conversation
Collaborator
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
Collaborator
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
cdc600f to
cf9ffa6
Compare
Author
|
@ianlancetaylor Could you take a look at this. Its a pretty simple fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been hitting this issue on macOS where backtrace errors out early even though it can still find symbols for some libraries. This happens when I am loading my library dynamically from python, so I assume its some python libraries that are causing issues.
I'm not quite sure if the logic here is correct. It works in my use cases, but I think I need someone who knows the codebase to verify it is correct.