Avoid recursion in resolve_unit_addrs_overlap#156
Open
MikailBag wants to merge 1 commit intoianlancetaylor:masterfrom
Open
Avoid recursion in resolve_unit_addrs_overlap#156MikailBag wants to merge 1 commit intoianlancetaylor:masterfrom
MikailBag wants to merge 1 commit intoianlancetaylor:masterfrom
Conversation
This patch replaces recursion with explicit stack of enclosing ranges. This fixes stack overflow on certain binaries when initialization happens inside a fiber. See ianlancetaylor#155 for original discussion.
MikailBag
force-pushed
the
overlap-no-rec
branch
from
5921018 to
bf7888f
Compare
MikailBag
commented
Apr 29, 2025
Author
MikailBag
left a comment
MikailBag
left a comment
There was a problem hiding this comment.
Here are some questions I've got while writing this patch.
| && ((struct unit_addrs**)enclosing->base)[enclosing_count-1]->high <= old_addrs[from].low) | ||
| { | ||
| enclosing_count--; | ||
| enclosing->alc += sizeof (struct unit_addrs*); |
Author
There was a problem hiding this comment.
What I want to do here is enclosing.pop_back(). I have found backtrace_vector_grow, but didn't find inverse function that shrinks used part of the allocation.
| *addrs_vec = new_vec; | ||
| backtrace_vector_free (state, &enclosing, error_callback, data); | ||
| if (walk_ok) | ||
| *addrs_vec = new_vec; |
Author
There was a problem hiding this comment.
Previously return code from walk subroutine was ignored here. Was that intended?
| @@ -1615,8 +1615,7 @@ unit_addrs_search (const void *vkey, const void *ventry) | |||
|
|
|||
| static int | |||
| resolve_unit_addrs_overlap_walk (struct backtrace_state *state, | |||
Author
There was a problem hiding this comment.
I'm not sure if this code path is covered by existing tests. Should I add a unit test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces recursion with explicit stack of enclosing ranges. This fixes stack overflow on certain binaries when initialization happens inside a fiber.
See #155 for original discussion.