Conversation
This is needed to the actual renderer can escape (or not) the text value. Depending on the escape parameter on the renderer
These are needed by mistune renderer
Contributor
Author
|
Forgot to pull master, so .. I need to fix that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed mistune was pinned to version 0.8.4, I updated it to v 3.0.1 (which covers #81 and #82 ((sorry))), all tests passing too.
While at it, I added the escape parameter mentioned on #34, which enables the rendering of quotes and other symbols instead of html escaped symbols.
I added that to the library but not to the CLI, the default is to not escape HTML stuff.
My main goal is to be able to get unescaped HTML, mainly for linking other confluence pages and maybe adding macros as mentioned on #34, But I though the new Mistune could handle it, let's see if that works.