Conversation
- Replace dynamic string refs with function refs for Vue 3 compatibility - Add fieldRefs data property to store child component references - Add setFieldRef() method to collect refs from function ref callbacks - Update fill() method to use fieldRefs object for accessing child components - Add cleanup for fieldRefs in beforeUnmount lifecycle hook The previous fix using :ref="'field-' + attribute" didn't work reliably in Vue 3's v-for loops. Function refs provide direct access to components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
:ref="'field-' + field.attribute"with:ref="(el) => setFieldRef(field.attribute, el)"fieldRefsdata property to store child field component referencessetFieldRef()method to properly collect and manage child component refsfill()method to use the newfieldRefsobject for accessing child componentsfieldRefsinbeforeUnmountlifecycle hookTechnical Details
:ref="'field-' + x"create arrays but are unreliable to access via$refs[key]:ref="(el) => refs[key] = el"provide direct access to component instancesTest Plan