Make metadata optional in Scenario class #1883
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the metadata field optional in the Scenario class to handle API responses that may not include metadata for certain scenarios.
Key changes:
- Updated
metadatafield type annotation fromstrtostr | Nonewith default valueNone - Reorganized
__init__parameter order to place required parameters before optional ones
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iMicknl
added a commit
that referenced
this pull request
Jan 8, 2026
Add additional test fixtures, which would have helped to spot #1883 regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes home-assistant/core#160443