fix: delete file on write failure and preserve parent directory#27
Merged
nabil-Tounarti merged 6 commits intomainfrom Nov 7, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the cleanup behavior in the download_file function by changing the error handling logic to only delete the failed file instead of removing the entire parent directory, preventing accidental deletion of existing directories when a file write fails.
Key changes:
- Modified cleanup logic to remove only the failed file instead of the parent directory when write operations fail
- Added error variable capture for better error logging
- Added comprehensive test coverage for the new cleanup behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Natchica
reviewed
Nov 7, 2025
Natchica
approved these changes
Nov 7, 2025
jbern0rd
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.