feat: Return all bulk dataset processing errors#25
Merged
nabil-Tounarti merged 10 commits intomainfrom Oct 29, 2025
Merged
Conversation
…plicateStatusCause>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling in the pre-compute stage by collecting and returning all encountered errors instead of failing on the first error. This allows for more comprehensive error reporting and better debugging capabilities.
Key changes:
- Modified
read_args()to return bothPreComputeArgsand a vector of errors instead of a singleResult - Updated error collection to continue processing after encountering errors in dataset and input file handling
- Enhanced
PreComputeInputFileDownloadFailederror to include the file index
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pre-compute/src/compute/pre_compute_args.rs | Changed read_args() to collect multiple errors during argument parsing and added comprehensive tests for error collection scenarios |
| pre-compute/src/compute/pre_compute_app.rs | Updated run() and download_input_files() to collect errors instead of early returns, allowing continued processing |
| pre-compute/src/compute/errors.rs | Modified PreComputeInputFileDownloadFailed to include file index for better error identification |
| pre-compute/src/compute/app_runner.rs | Updated error handling to work with vector of causes instead of single cause |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jbern0rd
reviewed
Oct 28, 2025
jbern0rd
reviewed
Oct 28, 2025
jbern0rd
reviewed
Oct 28, 2025
Natchica
approved these changes
Oct 29, 2025
jbern0rd
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.