ci: change ci to reusable workflow#36
Merged
TartanLeGrand merged 5 commits intodevelopfrom Mar 21, 2025
Merged
Conversation
TartanLeGrand
force-pushed
the
ci/use-reusable
branch
9 times, most recently
from
1a629c0 to
cc79de5
Compare
TartanLeGrand
force-pushed
the
ci/use-reusable
branch
from
8eb30ba to
3465412
Compare
zguesmi
reviewed
Mar 5, 2025
TartanLeGrand
force-pushed
the
ci/use-reusable
branch
from
3465412 to
5ff76d4
Compare
TartanLeGrand
force-pushed
the
ci/use-reusable
branch
5 times, most recently
from
ff8a921 to
eb52db7
Compare
🔒 Trivy Security Scan ResultsClick to expand detailed results |
🔒 Trivy Security Scan ResultsClick to expand detailed results |
🔒 Trivy Security Scan ResultsClick to expand detailed results |
Contributor
|
The Trivy Security Scan results seem to generate many comments in the PR, creating a lot of noise. Will it always be like this? Is it possible to reduce the noise a bit? |
Contributor
Author
I think we can add an input that defines where the result appears or modify the script to get the trivy comment before modifying it. |
zguesmi
reviewed
Mar 11, 2025
.github/workflows/docker-push.yml
Outdated
| on: | ||
| push: | ||
| tags: | ||
| - '*' # Trigger on any tag it is pushed by release workflow |
Contributor
Author
There was a problem hiding this comment.
It's mean on any tags, any branchs
Member
There was a problem hiding this comment.
Actually, we want to only build tagged docker images on tags coming from main (for vX.Y.Z tags) and release (for vX.Y.Z-rc*) branches.
Contributor
Author
There was a problem hiding this comment.
It's build only the docker when we add a tag in branch. And we can trigger an manual deploy with get the latest vX.Y.Z tag and add +dev+sha.
Member
There was a problem hiding this comment.
I don't see this part in iExecBlockchainComputing/github-actions-workflows/.github/workflows/docker-build.yml
Contributor
Author
There was a problem hiding this comment.
This is normal as it is a docker build workflow 😄
Member
There was a problem hiding this comment.
Yeah, sorry I see that we kept the tests part in main.yml. In this case, what's the benefit of docker-test.yml job?
Contributor
Author
There was a problem hiding this comment.
Check if the docker build
.github/workflows/docker-push.yml
Outdated
|
|
||
| jobs: | ||
| build-and-release: | ||
| if: github.event.ref_type == 'tag' |
Contributor
There was a problem hiding this comment.
Why duplicating code?
Maybe something like
if type == tag, image-tag = ${{ github.ref_name }} else [...]
then use docker-build composite
Contributor
Author
There was a problem hiding this comment.
No if else on github action but we can dedup with an use like this :
Contributor
There was a problem hiding this comment.
env before the if job condition is great yes 👍
🔒 Trivy Security Scan ResultsClick to expand detailed results |
gfournierPro
approved these changes
Mar 13, 2025
🔒 Trivy Security Scan ResultsClick to expand detailed results |
Le-Caignec
approved these changes
Mar 17, 2025
Contributor
Author
|
Needs in :
👀 #42 |
TartanLeGrand
force-pushed
the
ci/use-reusable
branch
from
2100605 to
bef15b9
Compare
🔒 Trivy Security Scan ResultsClick to expand detailed results |
1 similar comment
🔒 Trivy Security Scan ResultsClick to expand detailed results |
🔒 Trivy Security Scan ResultsClick to expand detailed results |
1 similar comment
🔒 Trivy Security Scan ResultsClick to expand detailed results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to configuration files and workflows to streamline the Docker image build and deployment process. The most important changes are the addition of an
.editorconfigfile, the removal of a redundant GitHub Actions workflow, and the introduction of new workflows for Docker image building and testing.Configuration improvements:
.editorconfig: Added a new configuration file to enforce consistent coding styles across the project.Workflow changes:
.github/workflows/build-push-docker.yml: Removed the existing workflow for building and pushing Docker images, which included multiple steps and conditional checks..github/workflows/docker-push.yml: Added a new workflow to build and push Docker images using a reusable workflow fromiExecBlockchainComputing. This simplifies the process and reduces maintenance overhead..github/workflows/docker-test.yml: Introduced a new workflow to build and test Docker images on pull requests, ensuring that changes are validated before merging.Docker configuration:
test-stack/docker-compose.yml: Updated the Dockerfile path for thevoucher-subgraph-deployerservice to point to the correct location.