Skip to content

feat: allow to start SMS for TDX framework and to expose TEE properties#317

Merged
jbern0rd merged 2 commits intomainfrom
feature/add-tdx-profile-and-tee-properties
Oct 31, 2025
Merged

feat: allow to start SMS for TDX framework and to expose TEE properties#317
jbern0rd merged 2 commits intomainfrom
feature/add-tdx-profile-and-tee-properties

Conversation

@jbern0rd
Copy link
Contributor

No description provided.

@jbern0rd jbern0rd self-assigned this Oct 31, 2025
@sonarqubecloud
Copy link

@jbern0rd jbern0rd requested a review from Copilot October 31, 2025 11:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the TDX TEE framework alongside existing SCONE and GRAMINE frameworks. The implementation follows the established patterns for framework integration and includes placeholder functionality that will be completed in future work.

  • Introduces TdxServicesProperties class to represent TDX framework configuration
  • Adds TdxSessionHandlerService with not-yet-implemented session handling
  • Extends test coverage for the new TDX framework variant

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
iexec-sms-library/src/main/java/com/iexec/sms/api/config/TdxServicesProperties.java New properties class for TDX framework configuration
iexec-sms-library/src/main/java/com/iexec/sms/api/config/TeeServicesProperties.java Registers TDX as a JSON subtype and removes outdated TODO comment
src/main/java/com/iexec/sms/tee/session/tdx/TdxSessionHandlerService.java New service with placeholder implementation for TDX session handling
src/main/java/com/iexec/sms/tee/config/TeeWorkerInternalConfiguration.java Adds bean factory method for TDX properties map
src/main/java/com/iexec/sms/tee/TeeController.java Adds final modifiers to constructor parameters
src/main/java/com/iexec/sms/tee/OnTeeFrameworkCondition.java Fixes missing closing bracket in log message and updates copyright year
src/main/resources/application-tdx.yaml Configuration template for TDX worker pipelines
src/test/java/com/iexec/sms/version/VersionControllerTests.java Refactors test to use switch expression with TDX case and wildcard import
src/test/java/com/iexec/sms/tee/config/TeeWorkerInternalConfigurationTests.java Migrates to AssertJ assertions, replaces Arrays.asList with List.of, and adds test for TDX properties
src/test/java/com/iexec/sms/tee/session/tdx/TdxSessionHandlerServiceTests.java Test coverage for TDX session handler placeholder implementation
iexec-sms-library/src/test/java/com/iexec/sms/api/config/TdxServicesPropertiesTests.java Test coverage for TDX properties serialization/deserialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbern0rd jbern0rd merged commit 0b596f5 into main Oct 31, 2025
9 checks passed
@jbern0rd jbern0rd deleted the feature/add-tdx-profile-and-tee-properties branch October 31, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants