Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the TDX TEE framework alongside existing SCONE and GRAMINE frameworks. The implementation follows the established patterns for framework integration and includes placeholder functionality that will be completed in future work.
- Introduces
TdxServicesPropertiesclass to represent TDX framework configuration - Adds
TdxSessionHandlerServicewith not-yet-implemented session handling - Extends test coverage for the new TDX framework variant
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
iexec-sms-library/src/main/java/com/iexec/sms/api/config/TdxServicesProperties.java |
New properties class for TDX framework configuration |
iexec-sms-library/src/main/java/com/iexec/sms/api/config/TeeServicesProperties.java |
Registers TDX as a JSON subtype and removes outdated TODO comment |
src/main/java/com/iexec/sms/tee/session/tdx/TdxSessionHandlerService.java |
New service with placeholder implementation for TDX session handling |
src/main/java/com/iexec/sms/tee/config/TeeWorkerInternalConfiguration.java |
Adds bean factory method for TDX properties map |
src/main/java/com/iexec/sms/tee/TeeController.java |
Adds final modifiers to constructor parameters |
src/main/java/com/iexec/sms/tee/OnTeeFrameworkCondition.java |
Fixes missing closing bracket in log message and updates copyright year |
src/main/resources/application-tdx.yaml |
Configuration template for TDX worker pipelines |
src/test/java/com/iexec/sms/version/VersionControllerTests.java |
Refactors test to use switch expression with TDX case and wildcard import |
src/test/java/com/iexec/sms/tee/config/TeeWorkerInternalConfigurationTests.java |
Migrates to AssertJ assertions, replaces Arrays.asList with List.of, and adds test for TDX properties |
src/test/java/com/iexec/sms/tee/session/tdx/TdxSessionHandlerServiceTests.java |
Test coverage for TDX session handler placeholder implementation |
iexec-sms-library/src/test/java/com/iexec/sms/api/config/TdxServicesPropertiesTests.java |
Test coverage for TDX properties serialization/deserialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nabil-Tounarti
approved these changes
Oct 31, 2025
Natchica
approved these changes
Oct 31, 2025
thewhitewizard
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.