Skip to content

feat: stop embedding category, app and dataset models in deal model #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbern0rd merged 2 commits into from
Dec 1, 2025

test: improve TaskDescription coverage

9a131f8
Select commit
Loading
Failed to load commit list.
Merged

feat: stop embedding category, app and dataset models in deal model #163

test: improve TaskDescription coverage
9a131f8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 28, 2025 in 25s

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 297 in src/test/java/com/iexec/commons/poco/chain/IexecHubAbstractServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "chainApp"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIr8zu17z5OCyyfU&open=AZrKBIr8zu17z5OCyyfU&pullRequest=163

Check warning on line 298 in src/test/java/com/iexec/commons/poco/chain/IexecHubAbstractServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "chainCategory"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIr8zu17z5OCyyfV&open=AZrKBIr8zu17z5OCyyfV&pullRequest=163

Check warning on line 81 in src/test/java/com/iexec/commons/poco/task/TaskDescriptionTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated method, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIvVzu17z5OCyyfY&open=AZrKBIvVzu17z5OCyyfY&pullRequest=163

Check warning on line 35 in src/main/java/com/iexec/commons/poco/chain/ChainDeal.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIwJzu17z5OCyyfa&open=AZrKBIwJzu17z5OCyyfa&pullRequest=163

Check warning on line 186 in src/main/java/com/iexec/commons/poco/task/TaskDescription.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIwhzu17z5OCyyfe&open=AZrKBIwhzu17z5OCyyfe&pullRequest=163

Check warning on line 80 in src/test/java/com/iexec/commons/poco/task/TaskDescriptionTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated method, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIvVzu17z5OCyyfX&open=AZrKBIvVzu17z5OCyyfX&pullRequest=163

Check warning on line 82 in src/test/java/com/iexec/commons/poco/task/TaskDescriptionTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated method, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKWhqEx-vyv0lQvivx&open=AZrKWhqEx-vyv0lQvivx&pullRequest=163

Check warning on line 79 in src/test/java/com/iexec/commons/poco/task/TaskDescriptionTests.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated method, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIvVzu17z5OCyyfW&open=AZrKBIvVzu17z5OCyyfW&pullRequest=163

Check warning on line 216 in src/main/java/com/iexec/commons/poco/chain/IexecHubAbstractService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIvvzu17z5OCyyfZ&open=AZrKBIvvzu17z5OCyyfZ&pullRequest=163

Check warning on line 45 in src/main/java/com/iexec/commons/poco/chain/ChainDeal.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIwJzu17z5OCyyfc&open=AZrKBIwJzu17z5OCyyfc&pullRequest=163

Check warning on line 40 in src/main/java/com/iexec/commons/poco/chain/ChainDeal.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIwJzu17z5OCyyfb&open=AZrKBIwJzu17z5OCyyfb&pullRequest=163

Check warning on line 88 in src/main/java/com/iexec/commons/poco/chain/ChainDeal.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=com.iexec.commons%3Aiexec-commons-poco&issues=AZrKBIwJzu17z5OCyyfd&open=AZrKBIwJzu17z5OCyyfd&pullRequest=163
View more details on SonarQubeCloud