Skip to content

test: remove dependency on upload.wikimedia.org in FileHelperTests due to 403 HTTP code #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbern0rd merged 1 commit into from
Sep 2, 2025
Merged

test: remove dependency on upload.wikimedia.org in FileHelperTests due to 403 HTTP code #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 23 additions & 51 deletions src/test/java/com/iexec/common/utils/FileHelperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,13 @@
class FileHelperTests {

private static final String TEST_FOLDER = "/tmp/iexec-test";
// http

private static final String HTTP_URL = "http://icons.iconarchive.com/icons/" +
"cjdowner/cryptocurrency-flat/512/iExec-RLC-RLC-icon.png";
// private static final String HTTP_FILENAME = "iExec-RLC-RLC-icon.png";
private static final String HTTP_FILE_DIGEST =
private static final String HTTPS_URL = "https://icons.iconarchive.com/icons/" +
"cjdowner/cryptocurrency-flat/512/iExec-RLC-RLC-icon.png";
private static final String FILE_DIGEST =
"0x4d8401fd4484f07c202c0a2b9ce6907eabd69efae0cec3956f1a56a6b19a9daa";
// https
private static final String HTTPS_URL = "https://upload.wikimedia.org" +
"/wikipedia/commons/thumb/6/65/600px_Black_bordered_HEX-0082D6.svg/600px-600px_Black_bordered_HEX-0082D6.svg.png";
// private static final String HTTPS_FILENAME = "token.svg";
private static final String HTTPS_FILE_DIGEST =
"0x45a4b7a3666f3885f3e5ac0e8c865c6f841890d2beb8d279c2bab9578403e05f";
// redirection
// private static final String REDIRECTION_URL = "https://goo.gl/t8JxoX";
// private static final String REDIRECTION_FILE_DIGEST = "TODO";

private static final String ICON_PNG = "icon.png";

Expand All @@ -73,6 +65,7 @@ void shouldCreateFileWithContent() throws IOException {
assertThat(content).isEqualTo(data);
}

// region createFolder
@Test
void shouldCreateFolder() {
String folderPath = TEST_FOLDER + "/folder";
Expand Down Expand Up @@ -114,8 +107,9 @@ void shouldCreateFolderRecursively() {
.exists()
.isDirectory();
}
// endregion

// region delete file or folder
// region deleteFile
@Test
void shouldDeleteFile() {
String filePath = TEST_FOLDER + "/test.txt";
Expand All @@ -140,7 +134,9 @@ void shouldNotDeleteNonExistingFile() {
assertThat(isDeleted).isFalse();
assertThat(deletedFile).doesNotExist();
}
// endregion

// region deleteFolder
@Test
void shouldDeleteFolder() {
String folderPath = TEST_FOLDER + "/folder";
Expand Down Expand Up @@ -196,8 +192,7 @@ void shouldZipFolder() {
assertThat(zipFile.getAbsolutePath()).isEqualTo(TEST_FOLDER + "/taskId.zip");
}

// downloadFile(url, dir, name)

// region downloadFile(url, dir, name)
@Test
void shouldDownloadFileWithName() {
String downloadedFilePath = FileHelper.downloadFile(
Expand All @@ -206,7 +201,7 @@ void shouldDownloadFileWithName() {
assertThat(new File(downloadedFilePath)).exists();
// check that the correct file is downloaded
assertThat(FileHashUtils.sha256(new File(downloadedFilePath)))
.isEqualTo(HTTP_FILE_DIGEST);
.isEqualTo(FILE_DIGEST);
}

@Test
Expand All @@ -217,21 +212,9 @@ void shouldDownloadFileWithNameFromHttpsUrl() {
assertThat(new File(TEST_FOLDER + "/token.svg")).exists();
// check that the correct file is downloaded
assertThat(FileHashUtils.sha256(new File(downloadedFilePath)))
.isEqualTo(HTTPS_FILE_DIGEST);
.isEqualTo(FILE_DIGEST);
}

// TODO
// @Test
// void shouldDownloadFileWithNameWithHttpRedirection() {
// String downloadedFilePath = FileHelper.downloadFile(
// REDIRECTION_URL, TEST_FOLDER, ICON_PNG);
// assertThat(downloadedFilePath).isEqualTo(TEST_FOLDER + "/icon.png");
// assertThat(new File(TEST_FOLDER + "/icon.png")).exists();
// // check that the correct file is downloaded
// assertThat(FileHashUtils.sha256(new File(downloadedFilePath)))
// .isEqualTo(REDIRECTION_FILE_DIGEST);
// }

@Test
void shouldNotDownloadFileWithEmptyUrl() {
assertThat(FileHelper.downloadFile("", TEST_FOLDER, "file.txt")).isEmpty();
Expand Down Expand Up @@ -263,13 +246,13 @@ void shouldNotDownloadFileSinceCannotCreateFolder() {
HTTP_URL, "/unauthorized", ICON_PNG);
assertThat(downloadedFilePath).isEmpty();
}
// endregion

// TODO
// @Test
// void shouldCleanCreatedParentFolderWhenFailingToWriteDownloadedFile() {}

// readFileBytesFromUri(url)

// region readFileBytesFromUrl(url)
@Test
void shouldReadFileBytesFromUrl() {
byte[] bytes = FileHelper.readFileBytesFromUrl(HTTP_URL);
Expand All @@ -281,9 +264,9 @@ void shouldNotReadFileBytesFromBadUrl() {
byte[] bytes = FileHelper.readFileBytesFromUrl("http://bad-url");
assertThat(bytes).isNull();
}
// endregion

// downloadFile(url, dir)

// region downloadFile(url, dir)
@Test
void shouldDownloadFileWithHttpUrl() {
String downloadedFilePath = downloadFile(HTTP_URL, TEST_FOLDER);
Expand All @@ -292,7 +275,7 @@ void shouldDownloadFileWithHttpUrl() {
assertThat(new File(TEST_FOLDER + "/" + filename)).exists();
// check that the correct file is downloaded
assertThat(FileHashUtils.sha256(new File(downloadedFilePath)))
.isEqualTo(HTTP_FILE_DIGEST);
.isEqualTo(FILE_DIGEST);

}

Expand All @@ -304,23 +287,11 @@ void shouldDownloadFileWithHttpsUrl() {
assertThat(new File(TEST_FOLDER + "/" + filename)).exists();
// check that the correct file is downloaded
assertThat(FileHashUtils.sha256(new File(downloadedFilePath)))
.isEqualTo(HTTPS_FILE_DIGEST);
.isEqualTo(FILE_DIGEST);
}
// endregion

// TODO
// @Test
// void shouldDownloadFileWithRedirectionUrl() {
// String downloadedFilePath = downloadFile(REDIRECTION_URL, TEST_FOLDER);
// String filename = Paths.get(REDIRECTION_URL).getFileName().toString();
// assertThat(downloadedFilePath).isEqualTo(TEST_FOLDER + "/" + filename);
// assertThat(new File(TEST_FOLDER + "/" + filename)).exists();
// // check that the correct file is downloaded
// assertThat(FileHashUtils.sha256(new File(downloadedFilePath)))
// .isEqualTo(REDIRECTION_FILE_DIGEST);
// }

// exists()

// region exists()
@Test
void shouldFindFolder() {
assertThat(FileHelper.exists("/tmp")).isTrue();
Expand All @@ -336,9 +307,9 @@ void shouldFindFile() {
void shouldNotFindFolder() {
assertThat(FileHelper.exists("/not-found")).isFalse();
}
// endregion

// removeZipExtension(path)

// region removeZipExtension(path)
@Test
void shouldRemoveZipExtension() {
String fileName = FileHelper.removeZipExtension("/some/where/file.zip");
Expand All @@ -356,5 +327,6 @@ void shouldNotRemoveZipExtensionSinceWrongExtension() {
String fileName = FileHelper.removeZipExtension("/some/where/file.bla");
assertThat(fileName).isEmpty();
}
// endregion

}