Skip to content

fix: call new hasEnoughGas method to fall back on cached value on communication failure #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbern0rd merged 1 commit into from
Dec 16, 2025
Merged

fix: call new hasEnoughGas method to fall back on cached value on communication failure #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
services:

ibaa-chain:
image: docker-regis.iex.ec/poco-chain:1.1.0-poco-v6.1.0-contracts-voucher-v1.0.0-nethermind
image: docker-regis.iex.ec/poco-chain:1.2.2-poco-v6.2.0-contracts-nethermind
expose:
- "8545"

Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# x-release-please-start-version
version=9.0.4
# x-release-please-end
iexecCommonsPocoVersion=5.3.1
iexecCommonsPocoVersion=5.4.0
iexecCommonVersion=9.2.0

nexusUser
Expand Down
4 changes: 0 additions & 4 deletions src/main/java/com/iexec/blockchain/chain/IexecHubService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,6 @@ public TransactionReceipt waitForTxMined(final SubmittedTx submittedTx) throws I
return receipt;
}

public boolean hasEnoughGas() {
return hasEnoughGas(credentials.getAddress());
}

/**
* Check if the task is defined on-chain and has the {@link ChainTaskStatus#UNSET} status.
*
Expand Down
6 changes: 3 additions & 3 deletions ...in/java/com/iexec/blockchain/command/task/initialize/TaskInitializeBlockchainService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ public TaskInitializeBlockchainService(final IexecHubService iexecHubService) {

@Override
public boolean canSendBlockchainCommand(final TaskInitializeArgs args) {
String chainTaskId = args.getChainTaskId();
final String chainTaskId = args.getChainTaskId();
if (!iexecHubService.hasEnoughGas()) {
logError(chainTaskId, args, "task is not revealing");
logError(chainTaskId, args, "insufficient gas");
return false;
}
if (!iexecHubService.isTaskInUnsetStatusOnChain(args.getChainTaskId())) {
logError(chainTaskId, args, "task is not unset");
logError(chainTaskId, args, "task already exist on-chain");
return false;
}
if (!iexecHubService.isBeforeContributionDeadline(args.getChainDealId())) {
Expand Down