Skip to content

Expose Requesting as injectable dependency on Server#47

Merged
i2h3 merged 1 commit into
mainfrom
copilot/make-requesting-object-injectable
May 13, 2026
Merged

Expose Requesting as injectable dependency on Server#47
i2h3 merged 1 commit into
mainfrom
copilot/make-requesting-object-injectable

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

  • Make Requesting protocol public
  • Add session parameter to the public convenience init of Server, defaulting to URLSession(configuration: .ephemeral)
  • Simplify parameter signature: use any Requesting = URLSession(configuration: .ephemeral) directly instead of optional + nil-coalescing

Copilot AI linked an issue May 13, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Expose requesting object as injectable in Server initializer Expose Requesting as injectable dependency on Server May 13, 2026
Copilot finished work on behalf of i2h3 May 13, 2026 09:20
Copilot AI requested a review from i2h3 May 13, 2026 09:20
@i2h3 i2h3 marked this pull request as ready for review May 13, 2026 09:21
Comment thread Sources/Rainmaker/Server.swift Outdated
Copilot finished work on behalf of i2h3 May 13, 2026 09:25
Copilot AI requested a review from i2h3 May 13, 2026 09:25
@i2h3 i2h3 force-pushed the copilot/make-requesting-object-injectable branch 2 times, most recently from bd39fbb to e965ec5 Compare May 13, 2026 09:50
@i2h3 i2h3 force-pushed the copilot/make-requesting-object-injectable branch from e965ec5 to b919870 Compare May 13, 2026 09:51
@i2h3 i2h3 merged commit 26d18ed into main May 13, 2026
7 checks passed
@i2h3 i2h3 deleted the copilot/make-requesting-object-injectable branch May 13, 2026 09:59
@i2h3 i2h3 added this to the 2.0.0 milestone May 13, 2026
@i2h3 i2h3 added the enhancement New feature or request label May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Injectable Requesting Object

2 participants