generalize script to support rhel8 and rhel9 derivates #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install script currently only works for RHEL 8 and 9, not for compatible derivates like Alma/Rocky/Oracle Linux.
This update generalizes the script top handle the family as "el8" or "el9".
It doesn't automatically update the system, if updates are pending. Instead it asks the user to do that. Automatically updating the system may have side effects and may require a system reboot, which does not happen automatically. Thus better let the user do it.
EL 9.6 includes the php module for 8.3, EL 8.10 includes mariadb 10.11 and php 8.2.
Instead of manually setting up the epel repository from fixed fedora urls, use the epel-release package included in the distro to set up epel.
Enable the crb repository for the derivates.
Don't start firewalld, if it is not running/active. Some systems do not have firewalld (e.g. it's not included in the cloud images, because the cloud infrastructure does firewalling).
Remove the redundant chcon run. It doesn't make sense to set the directory first to httpd_sys_content_t and then to httpd_sys_rw_content_t. Just set it to httpd_sys_rw_content_t. Nothing is written in between.