Open
Conversation
Collaborator
Author
|
The |
sakithb
force-pushed
the
fix-form-dark-mode-not-applied
branch
from
3ac3556 to
281d7b6
Compare
Collaborator
Author
|
Update docs: |
supun-io
reviewed
Dec 19, 2025
| style.textContent = formCss; | ||
| this.shadowRoot!.appendChild(style); | ||
|
|
||
| window.addEventListener( |
Member
There was a problem hiding this comment.
@Nadil-K what do you think?
On the one hand, I think we should not integrate external systems directly within the embed.
On the other hand, Hyvor Blogs is our own platform. It generally makes sense to have something like this in HP.
Initially, my thought was to handle this at the installation time, by giving the user a code snippet with a code like this included
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#389