memory: add move assignment to CWeakPointer#113
Merged
Conversation
vaxerski
reviewed
Jun 16, 2026
NotPppp1116
force-pushed
the
weakptr-move-assignment
branch
from
c5135ee to
c085b61
Compare
vaxerski
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, assigning a
CWeakPointerfrom an rvalue could fall back to copy assignment because the class had move constructors but no move-assignment operators. Add same-type and converting move assignment overloads that swap the stored pointers, matching the other pointer wrappers and avoiding explicit weak-reference count changes.The tests verify that both forms exchange the stored control blocks without changing either weak-reference count.
Related Hyprland performance cleanup: hyprwm/Hyprland#15147