core/wayland: route keyboard to the focused window, not the pointer one#91
Merged
Merged
Conversation
keys were delivered to whatever window the pointer was over, since there was no wl_keyboard.enter handler and routing used the pointer window. a dialog that focused a field on open got no keys until you moused over it and clicked. track the keyboard-focused window from wl_keyboard.enter/leave and route keys there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard input was delivered to whatever window the pointer was over. There was no
wl_keyboard.enterhandler, andonKeyrouted tom_currentWindow, which is set by pointer enter/leave.The effect: a window that focuses an element on open (a polkit-style password dialog calling
focus()afteropen()) received no keys until you moused over it and clicked. The compositor had given it keyboard focus, but the toolkit was looking at the pointer.Track the keyboard-focused window from
wl_keyboard.enter/leave(m_keyboardWindow) and route key events and key repeat there. Pointer events still usem_currentWindow.