element/textbox: vertically center single-line selection highlight#88
Merged
Merged
Conversation
UncleJ4ck
force-pushed
the
fix-textbox-selection-valign
branch
2 times, most recently
from
0f3d3e7 to
6c1852c
Compare
single-line text is drawn vcentered but the selection rect was placed at the pango layout top, so the highlight sat above the glyphs. center it to match.
UncleJ4ck
force-pushed
the
fix-textbox-selection-valign
branch
from
6c1852c to
d70f7fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-line textboxes draw their text vertically centered (the
VCENTERoffset applied inCTextElement::paint), but the selection highlight was positioned at the pango layout top, so it sat above the glyphs instead of on them. Most visible on password fields.Center the highlight to match when the textbox is single-line. Multiline selections are left alone since multiline text is top-aligned already.
Added a unit test that positions a single-line textbox, selects all with
Ctrl+A, and asserts the highlight's vertical center lands on the textbox center. It fails without the fix.