add more egl helpers and members to formats#46
Open
gulafaran wants to merge 6 commits into
Open
Conversation
add pixel layouts to the formats and a getReadbackFormat helper to be used with glreadpixels.
add bits for formats and getcolordepth helper.
vaxerski
reviewed
May 14, 2026
rename them to PIXEL_LAYOUT_* to avoid conflicts.
add an alphaAdded member to easily be able to get the drm format with alpha added if needed.
fillout missing members for R8 , GR88 , RGB888
add 4 more formats, cross referenced weston. RGBX8888, RGBA8888, BGRX8888, BGRA8888. also fix pixellayout type for 16bit integer formats. and swizzle typoes.
Contributor
Author
|
@vaxerski ok besides requiring some testing, any syntax nags here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add pixelLayout and getReadbackFormat because we cant rely on swizzle types to decide what readpixel format to use.
also add a bits and getColorDepth helper so we can get what kind of bits or depth the format actually is.