Remove pooling and other special cases for SHA-256 digests#985
Merged
ArneBab merged 5 commits intohyphanet:nextfrom Nov 11, 2024
Merged
Remove pooling and other special cases for SHA-256 digests#985ArneBab merged 5 commits intohyphanet:nextfrom
ArneBab merged 5 commits intohyphanet:nextfrom
Conversation
SHA256 digests are cheap to construct nowadays. The pooling mechanism is complex and microbenchmarks show that it actually reduces performance. Remove the pooling, but keep the return digest method for compatibility.
This is already checked during construction of Util.mdProviders, there is no need to do the WrapperManager.stop() dance here because this will never happen.
Since the removal of SHA256 digest pooling, SHA256.returnMessageDigest has become a no-op function. Remove all of its uses.
HashType had a special case around SHA256 but this is no longer needed since these digests are no longer pooled. Simplify and generalize the solution by having HashType create all digests, and reducing SHA256 to a compatibility wrapper offering a few convenience functions.
ArneBab
approved these changes
Oct 21, 2024
Contributor
ArneBab
left a comment
ArneBab
left a comment
There was a problem hiding this comment.
That’s great! I love seeing the double-try blocks become unnecessary and be removed.
Thank you!
Contributor
|
merged — thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During review of #831 it was observed that the overhead of pooling outweights that of constructing new digest instances.
This PR removes the pooling mechanism from the SHA256 helper class. Because the return-to-pool method is now a no-op, its usages are removed. The method is now deprecated, but remains for backwards compatibility.
While cleaning up I encountered the HashType enum, which had a special case for pooling of SHA-256 too. This deprecates the related return-to-pool method, and removes the special handling of SHA-256 message digest creation in this class.