fix(lint): remove blanket #![allow(...)] from main.rs and lib.rs#68
Merged
Conversation
Closes #16, closes #17. The blanket allow block was silencing 12 clippy lint categories across the whole crate. Restore clippy signal by removing the block, then fix each lint at the call site: - main.rs: replace `mod {abi,codegen,intercept,manifest,tier1,tier2};` with `use verisimiser::{abi, codegen, manifest};`. The binary crate was redeclaring the same modules as the library crate, which both duplicated the source and caused dead_code warnings on every library item the binary didn't happen to reference. Routing main through the lib crate eliminates the duplication and the warnings. - codegen/query.rs:124: collapse `format!("{}::text", format!(...))` nested call into a single `format!("{}.ctid::text", table_name)` (format_in_format_args). - manifest/mod.rs:309: the `if database == "sqlite" { "false" } else { "false" }` was a placeholder where both branches returned the same literal. Simulation is unimplemented across all backends; use a plain `let enable_simulation = "false";` with a comment noting the backend-dependent value should be added when simulation lands (if_same_then_else). `cargo clippy --all-targets -- -D warnings` is clean. All 26 unit tests pass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#![allow(...)]block fromsrc/main.rsandsrc/lib.rsso clippy signal is restored across the cratemod xxx;redeclarations inmain.rswithuse verisimiser::{abi, codegen, manifest};— eliminates source duplication between bin and lib crates, and the dead-code warnings that came from the bin crate seeing unused pub itemsCloses
Test plan
cargo clippy --all-targets -- -D warningscleancargo test --lib --bins)