ci(antipattern): allowlist legit TS bridge/adapter paths#24
Merged
Conversation
Adds tests/, test/, scripts/, mcp-adapter/, editors/vscode/, and broadens bindings/deno → bindings/ (covering bindings/typescript and bindings/assemblyscript too). The previous check failed on stapeln's own MCP adapter (vordr's HTTP-MCP server is Deno/TS by MCP spec) and Deno test runners. These are bridge/adapter code into non-ReScript ecosystems, structurally analogous to bindings/deno which was already excluded. The hard-stop on plain TypeScript application code outside these paths is preserved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the antipattern-check CI failure that has been firing on every PR.
Cause: stapeln's own MCP adapter (
container-stack/vordr/src/mcp-adapter/) is implemented in Deno/TS because the MCP protocol is TS-typed by spec — but the antipattern check only excludedbindings/deno/, not other legitimate bridge paths.Fix: broaden the allowlist to cover all bridge/adapter conventions:
bindings/(wasbindings/deno— also covers bindings/typescript, bindings/assemblyscript)tests/,test/— Deno test runnersscripts/— Deno build scriptsmcp-adapter/— MCP server adapterseditors/vscode/— VSCode extensionsHard-stop on plain TypeScript application code outside these paths is preserved.
Local dry-run on stapeln after the change: 0 TS files flagged (was 8).