fix(cerro-torre): pin Alire URL to explicit version (re-apply, closes #13)#21
Merged
Merged
Conversation
…load/ (#18) Closes #13. GitHub's /releases/latest/download/<filename> redirect only works when <filename> is an asset of the current latest release. Alire's asset filenames embed the version (alr-X.Y.Z-bin-...), so the previously hardcoded `alr-2.0.2-bin-...` filename returns 404 against /latest/ the moment a newer release ships — which has happened (current is 2.1.0). Switch to the explicit-version URL (releases/download/vX.Y.Z/) which ALWAYS works for the pinned version, regardless of what 'latest' is. ARG ALIRE_VERSION=2.1.0 lets downstream override the pin. Same pattern survives Alire releases without breaking.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies fix originally squash-merged as #18 and reverted as part of the rescript-ecosystem cleanup. Same content. Closes #13.
GitHub's /releases/latest/download/ redirect requires to be an asset of the current latest release. Alire embeds the version in the asset name, so a hardcoded version under /latest/download/ silently 404s when a new Alire ships.