Skip to content

feat(migration/msg): port 3 self-contained msg types (megaport STEP 8 follow-up)#74

Merged
hyperpolymath merged 1 commit into
mainfrom
feat/megaport-step8-msg-types
Jun 2, 2026
Merged

feat(migration/msg): port 3 self-contained msg types (megaport STEP 8 follow-up)#74
hyperpolymath merged 1 commit into
mainfrom
feat/megaport-step8-msg-types

Conversation

@hyperpolymath
Copy link
Copy Markdown
Owner

3 new .affine files (FeedbackMsg / OrbitalMsg / VideoCoordinationMsg) sitting on branch from 2026-05-31, never PR'd. Filed during 2026-06-02 estate orphan-branch sweep. Behind main by 5 commits — needs rebase if non-trivial conflict.

… follow-up)

Ports 3 src/msg/*.res files that are truly self-contained (no
cross-module `open Model` or `XxxModel.foo` qualified-path refs):

- OrbitalMsg.affine        (8 LoC) — pure sum type
- FeedbackMsg.affine       (11 LoC) — sum with Result<String,String>
- VideoCoordinationMsg.affine (11 LoC) — sum with Result<String,String>

All 3 pass `affinescript check`. Total: 30 LoC of .res ported.

These are the only currently-portable msg files; the other ~119 msg/
files all either `open Model` or use qualified `XxxModel.fooTab`
types — both blocked on affinescript#228 (in-tree qualified paths
in non-stdlib context).

Adjacent to panll#72 (the 11 src/modules/ ports). Same megaport
STEP 8 context, different subdirectory.

Refs standards#279 (megaport STEP 8), standards#252 (campaign UMBRELLA).
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 2, 2026

@hyperpolymath hyperpolymath merged commit 840fb52 into main Jun 2, 2026
18 of 22 checks passed
@hyperpolymath hyperpolymath deleted the feat/megaport-step8-msg-types branch June 2, 2026 11:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

🔍 Hypatia Security Scan

Findings: 108 issues detected

Severity Count
🔴 Critical 30
🟠 High 17
🟡 Medium 61

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Stale AI session file -- delete",
    "type": "stale",
    "file": "GEMINI.md",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "medium"
  },
  {
    "reason": "Issue in boj-build.yml",
    "type": "missing_timeout_minutes",
    "file": "boj-build.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in build-validation.yml",
    "type": "missing_timeout_minutes",
    "file": "build-validation.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "missing_timeout_minutes",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant