balance(levels): apply 4 valid analyser recommendations (refs #19)#131
Open
hyperpolymath wants to merge 2 commits into
Open
balance(levels): apply 4 valid analyser recommendations (refs #19)#131hyperpolymath wants to merge 2 commits into
hyperpolymath wants to merge 2 commits into
Conversation
Applies the four valid recommendations from balance-report.json. The three `guard_patrol_radius` recs were skipped — they were corrupted by the analyser bug fixed in #128 and need re-running before they're trustworthy. Applied: 1. **city.alert_threshold 0.25 → 0.40** — enable hasPowerSystem. Tutorial win rate was 99.8% (no challenge). UPS adds detection threshold +0.15 without introducing trap mechanics that don't belong in the tutorial. 2. **security.defence_density 0.190 → 0.143** — drop cascadeTrap from DB-SERVER. 64% of deaths were trap-cascades; canary still detects scans, SIEM still receives alerts via the standard pipeline. 3. **backbone.guard_spawn_rate 1.2 → 0.84** — remove backbone_edge AntiHacker (x=700). Win rate was 0% even after v2; the edge AntiHacker was the last density bottleneck before the Assassin. Bumps Expert guard count 3 → 2 in `getGuardCountForDifficulty` accordingly. 4. **backbone.defence_density 0.524 → 0.393** — drop cascadeTrap+timeBomb from NA-BACKBONE and cascadeTrap from ATLAS-ROUTER. 67% of deaths were trap-deaths; killSwitch + whitelist remain as the genuine expert-tier gating, but the trap-cascade chains that made the level un-recoverable are gone. Three remaining recs (city / dmz / scada `guard_patrol_radius`) need `balance-report.json` to be regenerated against the #128 analyser fix before they can be applied — they currently report guard_spawn_rate values under the wrong field name. Tracked as follow-up. Refs #19 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com>
2 tasks
…ures for balance recs Tests asserted on the OLD baseline values from before the balance analyser recommendations were applied. With #131 applying the 4 valid recs to LevelConfig.res, these assertions now hold the new values: - 'expert difficulty has 3 guards' → 2 (rec: backbone guard_spawn_rate 1.2 → 0.80) - 'city has no power system' → 'has power system' (rec: city alert_threshold 0.25 → 0.40) Also renamed the monotonicity check from 'increases' → 'is monotonic non-decreasing' since Tutorial=Easy=2 now and we only assert ≤. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com>
hyperpolymath
added a commit
that referenced
this pull request
Jun 1, 2026
## Summary Refreshes `ROADMAP.md` + `.machine_readable/6a2/STATE.a2ml` to reflect the 2026-06-01 session closeout: **ROADMAP.md** - Current State: balance analyser line updated — 4 of 7 recommendations applied, 3 patrol-radius recs deferred pending Julia regen - Near-Term: dropped the balance-application item (done) and the Playwright residuals item (done); kept Julia-regen + bestpractices.dev + editor rewrite - New `Completed (2026-06-01 session)` section: balance recs application, analyser patrol_radius fix, Playwright residuals split, Burble rename **STATE.a2ml** - `last-updated`: 2026-05-03 → 2026-06-01 - `test-status`: updated to 2011+ tests across 211 modules - `route-to-mvp`: Grumble → Burble; balance application moved to `applied`; idaptik#84 added - `critical-next-actions`: Julia regen first; #84 wait on affinescript#228 - `session-history.2026-06-01`: new entry with PRs merged/armed + issues closed/open ## Cross-references - Companion wiki update at `hyperpolymath/idaptik.wiki@0d8ab7f` (Home.md Current State + Recent Sessions + Burble note) - Sibling PR #131 (balance recs to LevelConfig.res) — still cycling at filing time; this PR's wording is timing-safe either way ## Test plan - [ ] CI green (governance + scan + A2ML + K9 + ReScript Compile) - [ ] No file content beyond `ROADMAP.md` + `.machine_readable/6a2/STATE.a2ml` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🔍 Hypatia Security ScanFindings: 71 issues detected
View findings[
{
"reason": "Issue in boj-build.yml",
"type": "missing_timeout_minutes",
"file": "boj-build.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in build-validation.yml",
"type": "missing_timeout_minutes",
"file": "build-validation.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in cflite-pr.yml",
"type": "missing_timeout_minutes",
"file": "cflite-pr.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in codeql.yml",
"type": "missing_timeout_minutes",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in containers.yml",
"type": "missing_timeout_minutes",
"file": "containers.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in containers.yml",
"type": "missing_timeout_minutes",
"file": "containers.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dco.yml",
"type": "missing_timeout_minutes",
"file": "dco.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the four valid recommendations from `balance-report.json` to `LevelConfig.res`. The three `guard_patrol_radius` recommendations were skipped — those values were corrupted by the analyser bug fixed in #128 and need a re-run before they're trustworthy.
Rationale per rec is in the commit body. Gameplay impact:
Follow-up
Three `guard_patrol_radius` recommendations remain ungated:
These need `balance-report.json` regenerated against the #128 analyser fix (which adds a `mean_patrol_radius` field to `LevelStats` and uses it correctly). Tracked separately.
Refs #19
🤖 Generated with Claude Code