fix(idaptik-ums): delete corrupted editor .res files (closes #116)#120
Merged
Merged
Conversation
Nine .res files in idaptik-ums/src/editor/ were misnamed compiled .res.mjs outputs masquerading as ReScript source — the "Generated by ReScript, PLEASE EDIT WITH CARE" banner is the smoking gun. Their original .res sources never existed in any commit; the first introduction (17ffc43) already shipped them as compiled .mjs renamed to .res. These files were never imported by App.res (the actual idaptik-ums entry point) and had no .res.mjs siblings. They are pure orphan dead code. This commit: - Deletes 9 corrupted .res files - Keeps EditorLevelCmd.res (authentic ReScript source, Gossamer IPC wrappers for the 12 level-building commands) - Adds README.adoc explaining the situation and future plan (.affine rewrite when user-module codegen lands) Closes #116. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com>
🔍 Hypatia Security ScanFindings: 71 issues detected
View findings[
{
"reason": "Issue in boj-build.yml",
"type": "missing_timeout_minutes",
"file": "boj-build.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in build-validation.yml",
"type": "missing_timeout_minutes",
"file": "build-validation.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in cflite-pr.yml",
"type": "missing_timeout_minutes",
"file": "cflite-pr.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in codeql.yml",
"type": "missing_timeout_minutes",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in containers.yml",
"type": "missing_timeout_minutes",
"file": "containers.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in containers.yml",
"type": "missing_timeout_minutes",
"file": "containers.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dco.yml",
"type": "missing_timeout_minutes",
"file": "dco.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "Issue in dogfood-gate.yml",
"type": "missing_timeout_minutes",
"file": "dogfood-gate.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
3 tasks
hyperpolymath
added a commit
that referenced
this pull request
Jun 1, 2026
…s already wired (#123) ## Summary The 2026-03-29 ROADMAP listed 10 \"Near-Term (code ready to build)\" items. An audit of the actual codebase on 2026-06-01 finds **8 of those 10 items already fully wired** across `src/app/`. The ROADMAP has drifted from reality — this PR realigns the doc with the code. No source-code changes. Documentation truthfulness only. ## Changes - **Current State date** 2026-03-29 → 2026-06-01 - **Current State narrative** refreshed (Jessica + Q gameplay loops, dual-alert HUD, editor cleanup #116→#120, E2E suite operational again #118→#121, #122 follow-up) - **Near-Term** trimmed from 10 items to 4: - Apply balance analyser recommendations (genuinely pending) - bestpractices.dev registration (external action) - 6 residual Playwright failures (tracks #122) - editor surface rewrite gated on AS user-module codegen (tracks #116 + affinescript#228) - **New \"Completed (2026-06-01 audit)\" section** with the 8 moved items, each annotated with file:line citations - **Long-Term** gains a ReScript→AffineScript migration line (parallel to the existing ReScript 13 line — both tracked separately) ## The 8 audited-as-done items, with citations | Item | Citation | |---|---| | `QPrograms.res` 13 programs, 4-slot deck | `GameLoop.res:27,94` + `PlayerState.res:57,83,145-149` + `LoadoutScreen.res:191-192` + `QViewScreen.res:431-438` | | `JessicaClass` → `PlayerAttributes` | renamed to `JessicaBackground.background`; `PlayerAttributes.makeWithClass` at `PlayerAttributes.res:41-51` | | `MoletaireHunger` gravity | `Moletaire.res:1052-1092` (in `update`) | | `MoletaireCoprocessors` multipliers | `Moletaire.res:229,276,441,457,467,476,485,520,555,1034,1051` | | `JessicaLoadout` 3-slot, 20 items | `GameLoop.res:35,100` + `PlayerState.res:56,82,117-138` + `LoadoutScreen.res:153,161` — 6 weapons + 8 tools + 6 consumables verified | | Dual alert HUD | `DualAlertBridge.res` (full bridge) + `HUD.res:76,86` + `GameLoop.res:25,93,886-894` | | Jessica customisation | `JessicaCustomiseScreen.res` (hair, colour, preview); reachable from `CharacterSelectScreen.res:343` | | Critical success/failure | `CriticalRoll.res`; applied at `WorldBuilder.res:1453+` (Jessica) + `QPrograms.res:376-379` (Q) | ## Why this matters Truthful roadmaps are load-bearing for: (a) prioritisation (don't re-implement what's already there), (b) contributor onboarding (knowing what's already wired), (c) cross-estate planning (idaptik's surface is referenced by issue threads in affinescript / standards / proven for migration sequencing). The estate has a documented preference for one-line truthful entries over aspirational lists (see panll#60 ROADMAP truthfulness pattern). ## Test plan - [x] Each \"moved-to-done\" claim verified by `grep -rn` over `src/` - [x] No source-code changes — diff is `ROADMAP.md` only - [x] DCO sign-off + GPG signature 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.resfiles inidaptik-ums/src/editor/were misnamed compiled.res.mjsoutputs masquerading as ReScript source (// Generated by ReScript, PLEASE EDIT WITH CAREbanner is the smoking gun)..ressources never existed in any commit — the very first introduction (17ffc43) already shipped them as compiled.mjsrenamed to.res. Recovery from history was not possible.App.res(the actualidaptik-umsentry point) and had no.res.mjssiblings. They were pure orphan dead code.What this PR does
.resfiles.EditorLevelCmd.res(authentic ReScript source — Gossamer IPC wrappers for the 12 level-building commands).README.adocto explain the situation and the future plan (.affinerewrite when AS user-module codegen lands; cross-references affinescript#228 + standards#279).Why
idaptik#116 documented the corruption with a "full recovery recipe" — but on investigation no recovery was possible because the original source never existed. The honest fix is to delete the dead code, acknowledge the loss, and leave a clear note for whoever rebuilds the editor in
.affine.build-validation.ymlonly buildsidaptik-ums/ffi/zig+vm/wasm— ReScript is not currently compiled in CI, so the corrupted files were a latent / dormant issue, not an active red. Deletion is safe.Test plan
EditorLevelCmd.respreserved.Closes #116.
🤖 Generated with Claude Code