fix: network ambulance bugs + improved PMTUD and latency diagnostics#12
Merged
Conversation
…ions) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- LICENSE: pure MPL-2.0 text for machine detection (GitHub, registries) - LICENSES/MPL-2.0.txt: standard MPL-2.0 text - LICENSES/PMPL-1.0-or-later.txt: Palimpsest License text - NOTICE: explains the dual-license relationship - Source SPDX headers remain PMPL-1.0-or-later This ensures OSI compliance checks pass while preserving PMPL as the governing license for source code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Four bugs prevented the network ambulance from running to completion: - SCRIPT_DIR in main.sh was overwritten by sourced scripts (renamed to MAIN_DIR) - set -e killed the script on expected non-zero returns from diagnostic functions (changed to `func || total_issues=$((total_issues + $?))` across all modules) - set -u crashed on uninitialized associative array key in duplicate IP check - set -eo pipefail crashed when grep found no IP on a down interface Also improved: - MTU test: binary search PMTUD with specific fix commands (temporary + permanent) - Latency test: single-pass with jitter, packet loss, and 5-tier quality classification - Added Quad9 as third DNS latency target - MTU mismatch now counts as a diagnostic issue Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bash src/main.sh diagnoseruns to completion on live network--helpand--dry-runmodes work🤖 Generated with Claude Code