Skip to content

fix(borrow): escape (*r inside doc-comment examples (unblocks main …#349

Merged
hyperpolymath merged 2 commits into
mainfrom
claude/fix-borrow-ml-comment-1304
May 24, 2026
Merged

fix(borrow): escape (*r inside doc-comment examples (unblocks main …#349
hyperpolymath merged 2 commits into
mainfrom
claude/fix-borrow-ml-comment-1304

Conversation

@hyperpolymath
Copy link
Copy Markdown
Owner

…gate)

Two print(*r) example fragments inside doc-comment blocks (lines 1115 and 1338) contained the literal substring (*r, which OCaml's lexer treats as a nested comment opener — bringing the outer comment to depth 2 with only one matching *) to close it. Result: "Comment not terminated" at EOF on every dune build. Marker count was 126 (* vs 124 *) (off by 2, one per offending example); after this patch it is 124 / 124.

This has blocked main's dune build since #335 (CORE-01 pt3 Slice A) merged, which is why every subsequent PR (#341, #344, the open #346) has shown build red regardless of its own changes. Tiny fix; high leverage.

Fix: insert a single space inside the parens — print( *r) — so the lexer sees ( * r ) rather than the comment-open token (* followed by r. Reader-friendly; the example still reads the same.

No behavioural change. No code touched. Comment text only.

Diagnosed by parallel claude (INT-03 / S5 thread). Refs #335

claude and others added 2 commits May 24, 2026 16:29
…gate)

Two `print(*r)` example fragments inside doc-comment blocks
(lines 1115 and 1338) contained the literal substring `(*r`,
which OCaml's lexer treats as a nested comment opener — bringing
the outer comment to depth 2 with only one matching `*)` to
close it. Result: "Comment not terminated" at EOF on every
`dune build`. Marker count was 126 `(*` vs 124 `*)` (off by 2,
one per offending example); after this patch it is 124 / 124.

This has blocked main's `dune build` since #335 (CORE-01 pt3
Slice A) merged, which is why every subsequent PR (#341, #344,
the open #346) has shown `build` red regardless of its own
changes. Tiny fix; high leverage.

Fix: insert a single space inside the parens — `print( *r)` —
so the lexer sees `(` `*` `r` `)` rather than the comment-open
token `(*` followed by `r`. Reader-friendly; the example still
reads the same.

No behavioural change. No code touched. Comment text only.

Diagnosed by parallel claude (INT-03 / S5 thread).
Refs #335
@hyperpolymath hyperpolymath merged commit e76b5f9 into main May 24, 2026
@hyperpolymath hyperpolymath deleted the claude/fix-borrow-ml-comment-1304 branch May 24, 2026 16:45
@github-actions
Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 130 issues detected

Severity Count
🔴 Critical 15
🟠 High 60
🟡 Medium 55

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Stray AI.a2ml in root -- use 0-AI-MANIFEST.a2ml only",
    "type": "banned",
    "file": "AI.a2ml",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Superseded by 0-AI-MANIFEST.a2ml",
    "type": "banned",
    "file": "AI.djot",
    "action": "delete",
    "rule_module": "root_hygiene",
    "severity": "high"
  },
  {
    "reason": "Issue in quality.yml",
    "type": "missing_workflow",
    "file": "quality.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in security-policy.yml",
    "type": "missing_workflow",
    "file": "security-policy.yml",
    "action": "create",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action hyperpolymath/standards/.github/workflows/governance-reusable.yml@main needs attention",
    "type": "unpinned_action",
    "file": "governance.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Action actions/checkout@v6 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Action denoland/setup-deno@v2 needs attention",
    "type": "unpinned_action",
    "file": "publish-jsr.yml",
    "action": "pin_sha",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/example/smoke_driver.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/cli.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/affinescript/affinescript/affinescript-deno-test/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants