Remove Snapshot's empty regions field#1509
Open
ludfjig wants to merge 1 commit into
Open
Conversation
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
ludfjig
added
the
kind/enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the Snapshot::regions field and its accessor from the host snapshot implementation, based on the fact that since #1385 that field has been unconditionally empty. The change simplifies snapshot state and removes now-dead restore logic that attempted to reconcile mapped regions.
Changes:
- Removed
Snapshot::regionsstorage and theregions()accessor. - Simplified
MultiUseSandbox::restore()to always unmap currently mapped dynamic regions (matching the prior behavior when snapshot regions were always empty). - Updated a page-table test to stop referencing snapshot regions and only assert the NULL page remains unmapped.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/hyperlight_host/src/sandbox/snapshot/mod.rs |
Removes the regions field/accessor from Snapshot and related always-empty initialization. |
src/hyperlight_host/src/sandbox/initialized_multi_use.rs |
Simplifies restore-time region cleanup by unmapping all currently mapped dynamic regions. |
src/hyperlight_host/src/mem/mgr.rs |
Updates tests to avoid using removed snapshot region metadata and focuses on NULL-page unmapped invariant. |
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
cleanup-snapshot-regions
branch
from
5e6e3d2 to
3210bca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Snapshot::regions. Since d2e4669 it has been unconditionally always empty.