-
Notifications
You must be signed in to change notification settings - Fork 155
Migrate from log to tracing crate for unified logging
#1122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
log to tracing crate for unified logging
|
@copilot tests are failing |
Co-authored-by: jsturtevant <648372+jsturtevant@users.noreply.github.com>
The test failures are pre-existing and not caused by the log-to-tracing migration. All 21 failing tests fail with I verified this by testing the same failing tests on the base commit (before our changes) - they also fail with the same Test results after migration:
The migration is complete and working correctly. Commit: 8fe82c4 |
|
@copilot resolve the conflicts |
Migration Plan: Replace
logcrate withtracingcrateSummary
Successfully migrated Hyperlight from
logcrate totracingcrate. The host code now usestracingmacros throughout, while guest environments maintainlogcompatibility through conversion layers. The migration maintains backward compatibility by keepinglogas a dependency for guest environments where it's needed for the logger implementation.Completed Changes
Phase 1: Core Infrastructure Updates ✅
Phase 2: Code Migration ✅
Phase 3: Test Infrastructure Updates ✅
Phase 4: Build & Validation ✅
Test Results
Architecture
Original prompt
tracingcrate instead oflogto create logs #1028💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.