Vendor wasm runtime#78
Merged
Merged
Conversation
078b24d to
6527bad
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
b10666f to
8458ad8
Compare
ludfjig
previously approved these changes
Jun 25, 2025
Contributor
ludfjig
left a comment
There was a problem hiding this comment.
Looks very reasonable to me
jsturtevant
previously approved these changes
Jun 25, 2025
Contributor
jsturtevant
left a comment
There was a problem hiding this comment.
couple small quesitons otherwise lgtm
8458ad8 to
f2d014f
Compare
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
ludfjig
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares
hyperlight-wasmto be publishable by vendoring the dependency onwasm_runtime.make-vendor-tarrecipe inJustfileto create avendor.tarfor bundling dependencies (wasm_runtimeandhyperlight_wasm_macro)build.rsto unpack thevendor.tarfile during the build process. This allows us to distribute the dependent crate as part ofhyperlight-wasmwasmtime-platform.hCargo.tomlto include metadata required by crates.io (description,license,repository)vendor.tarfile to theincludelist for publication.TODO (in another PR): Update CI workflows with the steps to publish the
hyperlight-wasmcrate.cargo package -p hyperlight-wasm --list)cargo publish