Fix certstore to use ResponseMsgType for identity message hook#5423
Open
aayushbaluni wants to merge 1 commit intohyperledger:mainfrom
Open
Fix certstore to use ResponseMsgType for identity message hook#5423aayushbaluni wants to merge 1 commit intohyperledger:mainfrom
aayushbaluni wants to merge 1 commit intohyperledger:mainfrom
Conversation
The certStore's RegisterMsgHook was incorrectly registered for RequestMsgType. Identity messages (certs) are delivered in pull responses (DataUpdate), not in requests (DataReq). RequestMsgType hooks receive empty items; ResponseMsgType hooks receive the actual identity messages. Fixes hyperledger#4934
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4934
The certStore's RegisterMsgHook was incorrectly registered for
RequestMsgType. Identity messages (certs) are delivered in pull responses (DataUpdate), not in requests (DataReq).In
pullstore.go, when aDataReqis received,itemsis empty (onlyitemIDsfrom digests are populated). When aDataUpdate(response) is received,itemscontains the actual identity messages. The hook iterates overmsgsto add identities to the mapper, so it must be registered forResponseMsgTypeto receive the certs.Root cause
Wrong message type in
RegisterMsgHook- RequestMsgType hooks receive empty items; ResponseMsgType hooks receive the actual identity messages from pull responses.Changes
gossip/gossip/certstore.go: ChangeRequestMsgTypetoResponseMsgTypeinRegisterMsgHookMade with Cursor