Merged
Conversation
Contributor
Author
|
@denyeart how do we remove a file that is no longer needed? |
Contributor
|
Buf is complaining about a non-compatible change. In this case I think we can force merge since BlockAttestation was never used in a release and therefore we don't care about this specific compatibility change. But let's check with @jt-nti who set up the buf rules to be sure there are no other considerations. @tock-ibm I do see 5 references to this file in buf.yaml, so please remove those references as part of this PR. |
Member
|
It does seem completely self contained so I can't see a problem if it was never used in a release. It would probably be a good idea to revert 632b3ef to take out the associated buf config changes. (I expect you'll still need to force the merge though.) |
As of commit 1325059f136198fd72c7d7ca3c5da762078d110a in hyperledger/fabric, the "BlockAttestation" object is no longer used. Signed-off-by: Yoav Tock <tock@il.ibm.com>
tock-ibm
force-pushed
the
remove-block-attestation
branch
from
7c783fc to
678b22d
Compare
Contributor
Author
Contributor
denyeart
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of commit 1325059f136198fd72c7d7ca3c5da762078d110a in hyperledger/fabric, the "BlockAttestation" object is no longer used. See: hyperledger/fabric#5126