Skip to content

refactor: use slices.Contains to simplify code #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfi79 merged 1 commit into from
Aug 28, 2025
Merged

refactor: use slices.Contains to simplify code #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions pkg/cid/cid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"encoding/hex"
"encoding/pem"
"fmt"
"slices"

"github.com/hyperledger/fabric-chaincode-go/v2/pkg/attrmgr"
"github.com/hyperledger/fabric-protos-go-apiv2/msp"
Expand Down Expand Up @@ -143,12 +144,7 @@ func (c *ClientID) HasOUValue(OUValue string) (bool, error) {
return false, fmt.Errorf("cannot obtain an X509 certificate for the identity")
}

for _, OU := range x509Cert.Subject.OrganizationalUnit {
if OU == OUValue {
return true, nil
}
}
return false, nil
return slices.Contains(x509Cert.Subject.OrganizationalUnit, OUValue), nil
}

// GetX509Certificate returns the X509 certificate associated with the client,
Expand Down